Skip to content

Conversation

@meganrm
Copy link
Contributor

@meganrm meganrm commented Aug 1, 2025

Time Estimate or Size

xsmall

Problem

when installing the app with vite, i got a typescript error

Could not find a declaration file for module '@aics/simularium-viewer'. '/Users/meganr/dev/simularium-org/simularium-viewer/es/index.js' implicitly has an 'any' type.
  There are types at '/Users/meganr/dev/simularium-org/binding-sim-edu/node_modules/@aics/simularium-viewer/type-declarations/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@aics/simularium-viewer' library may need to update its package.json or typings.ts(7016)

Solution

followed this documentation for exporting types https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@meganrm meganrm requested a review from a team as a code owner August 1, 2025 01:29
@meganrm meganrm requested review from frasercl and interim17 and removed request for a team August 1, 2025 01:29
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.15% 2583 / 11658
🔵 Statements 22.15% 2583 / 11658
🔵 Functions 25% 149 / 596
🔵 Branches 80.41% 349 / 434
File CoverageNo changed files found.
Generated in workflow #617 for commit 48521b6 by the Vitest Coverage Report Action

@meganrm
Copy link
Contributor Author

meganrm commented Aug 1, 2025

i tested a local install of both the website and the binding affinity app

@meganrm meganrm merged commit 746b4b7 into main Aug 2, 2025
6 checks passed
@meganrm meganrm deleted the fix/type-import branch August 2, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants